Skip to content

Conversation

@fredzqm
Copy link
Contributor

@fredzqm fredzqm commented Oct 14, 2025

No description provided.

jrothfeder and others added 3 commits October 13, 2025 11:16
* feat(dataconnect): add confirmation for Gemini schema generation

Instead of directly asking for an app description to generate a schema with Gemini, this change first asks the user to confirm if they want to use Gemini.

If the user confirms, it then prompts for the app description with a default value of "an app for ${setup.projectId}".

* prompts

* changelog

* m

* feedback

* typo

* metrics

* Update index.ts

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fredzqm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on streamlining the handling of the --json flag across the Firebase CLI, particularly within Firestore-related commands. It shifts the responsibility of producing JSON output from individual command logic to a more unified system, making command implementations cleaner and more consistent. Additionally, it introduces a user-friendly confirmation step in the firebase init dataconnect initialization process and updates associated analytics.

Highlights

  • Refactored JSON Output Handling: The --json flag handling has been centralized, removing conditional logger.info(JSON.stringify(...)) blocks from numerous Firestore commands. Commands now return the object to be JSONified directly, simplifying their implementation.
  • Improved firebase init dataconnect Flow: A confirmation prompt is now presented before asking for an app idea description in firebase init dataconnect, enhancing user experience. Analytics tracking for project status during Data Connect initialization has also been refined.
  • Removed json property from Options interface: The json property has been removed from the BaseOptions interface and its usage across various command options and tests has been updated to reflect the new centralized JSON output mechanism.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a significant refactoring of how the --json flag is handled across the CLI. The new approach standardizes JSON output by using the return value of a command's action, which is a clean and maintainable pattern. This is cleverly enforced by changing the json property on the options type to undefined and providing clear documentation. The changes are applied consistently across numerous commands. I've identified one case where this refactoring causes a functional regression in the JSON output for firestore:backups:list. Additionally, there are some nice UX improvements for firebase init dataconnect.


// TODO: Consider returning listBackupResponse instead for --json. This will
// be a breaking change but exposes .unreachable, not just .backups.
return backups;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This change introduces a regression for users of the --json flag. Previously, the full listBackupsResponse object (including the unreachable field) was printed as JSON. With this change, only the backups array is returned, and thus printed, losing the unreachable information for JSON consumers.

While the TODO comment acknowledges this, it would be better to avoid this regression. I suggest returning listBackupsResponse to maintain the existing behavior for JSON output. This would be a breaking change for programmatic users of the command who might rely on the return value being Backup[], but given the new command framework's convention of using the return value for JSON output, it's the more correct and consistent approach.

Suggested change
return backups;
return listBackupsResponse;

@joehan joehan merged commit 9903737 into next Oct 14, 2025
50 of 51 checks passed
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Oct 14, 2025
joehan added a commit that referenced this pull request Dec 10, 2025
* Update next to match master (#9313)

* Remove overrides that diverge the test configuration from the build configuration. (#9300)

Co-authored-by: Jamie Rothfeder <[email protected]>

* Fix misleading typing for options.json. (#9275)

* feat(dataconnect): Add confirmation for Gemini schema generation (#9282)

* feat(dataconnect): add confirmation for Gemini schema generation

Instead of directly asking for an app description to generate a schema with Gemini, this change first asks the user to confirm if they want to use Gemini.

If the user confirms, it then prompts for the app description with a default value of "an app for ${setup.projectId}".

* prompts

* changelog

* m

* feedback

* typo

* metrics

* Update index.ts

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

---------

Co-authored-by: Jamie Rothfeder <[email protected]>
Co-authored-by: Jamie Rothfeder <[email protected]>
Co-authored-by: Yuchen Shi <[email protected]>
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

* BREAKING: clean up monkey patching in functions emulator runtime (#9402)

1. Removed `functions.config()` Polyfill
Removed initializeRuntimeConfig() from `src/emulator/functionsEmulatorRuntime.ts`. This function manually read `.runtimeconfig.json` and set `CLOUD_RUNTIME_CONFIG` env var to polyfill the logic for old clients of the Functions SDK. Functions SDK has included this feature for more than 5+ years now.

2. Removed Callable Auth Monkey Patches
Removed wrapCallableHandler from src/emulator/functionsEmulatorRuntime.ts. that handled manual auth header swapping logic in src/emulator/functionsEmulator.ts. We now rely on the SDK's built-in skipTokenVerification feature shipped since 3.16.0.

3. Bumped Minimum SDK Version
Increased minimum required firebase-functions version from 3.15.1 to 3.16.0 (launched 4+ years ago) in `src/emulator/functionsEmulatorRuntime.ts`. This ensures users have an SDK that supports skipTokenVerification and likely handles .runtimeconfig.json loading correctly in emulation.

* BREAKING: hide functions:config:* commands by default (#9340)

We'll gate all mutating functions:config:* commands behind the new `legacyRuntimeConfigCommands` experiment. We'll keep functions:config:{get,export} available for inspection.

Includes some minor refactoring to align deprecation message across all surfaces.

```shell
$ firebase functions:config:set FOO=bar

Error: DEPRECATION NOTICE: Action required before March 2026

The functions.config() API and the Cloud Runtime Config service are deprecated. Deploys that rely on functions.config() will fail once Runtime Config shuts down in March 2026.

The legacy functions:config:* CLI commands are deprecated and will be removed before March 2026.

Migrate configuration to the Firebase Functions params APIs:

  import { defineJsonSecret } from "firebase-functions/params";

  const config = defineJsonSecret("RUNTIME_CONFIG");

  exports.myFunction = functions
    .runWith({ secrets: [config] })
    .https.onRequest((req, res) => {
      const apiKey = config.value().service.key;
      // ...
    });

To convert existing runtime config values, try the interactive migration command:

  firebase functions:config:export

Learn more: https://firebase.google.com/docs/functions/config-env#migrate-config

To run this legacy command temporarily, run the following command and try again:

  firebase experiments:enable legacyRuntimeConfigCommands
```

* BREAKING: Rewrite functions:config:export command (#9341)

Target the new defineJsonSecret API as migration target for functions.config() usage. The new API is a simpler migration target for existing functions.config() use cases.

Example flow:

```shell
$ firebase functions:config:export
i  This command retrieves your Runtime Config values (accessed via functions.config()) and exports them as a Secret Manager secret.

i  Fetching your existing functions.config() from danielylee-90... ✔  Fetched your existing functions.config().

i  Configuration to be exported:
⚠  This may contain sensitive data. Do not share this output.

{
   <CONFIG>
}

✔ What would you like to name the new secret for your configuration? RUNTIME_CONFIG

✔  Created new secret version projects/XXX/secrets/RUNTIME_CONFIG/versions/1

i  To complete the migration, update your code:

  // Before:
  const functions = require('firebase-functions');

  exports.myFunction = functions.https.onRequest((req, res) => {
    const apiKey = functions.config().service.key;
    // ...
  });

  // After:
  const functions = require('firebase-functions');
  const { defineJsonSecret } = require('firebase-functions/params');

  const config = defineJsonSecret("RUNTIME_CONFIG");

  exports.myFunction = functions
    .runWith({ secrets: [config] })  // Bind secret here
    .https.onRequest((req, res) => {
      const apiKey = config.value().service.key;
      // ...
    });

i  Note: defineJsonSecret requires firebase-functions v6.6.0 or later. Update your package.json if needed. i  Then deploy your functions:
  firebase deploy --only functions
```

* feat(firestore): return listBackupsResponse from firestore:backups:list --json (#9392)

The `firestore:backups:list --json` command now returns the full `listBackupsResponse` object instead of just the `backups` array. This provides more information to the user, including a list of unreachable locations.

* Break java (#9451)

* error out java version below 21

* error out java version below 21

* error out java version below 21

* update formatting

* Remove duplicate error message

* Update CHANGELOG.md to include breaking change

* update CI to java 21

* Add setup-java action to integration

---------

Co-authored-by: Joe Hanley <[email protected]>

* Removing support for .bolt rules (#9339)

* Removing support for .bolt rules

* Changelog

* Merging in master

* Stop following symlinks when archiving directories (#9284)

* Stop following symlinks when archiving directories

* Update exfil PR (#9289)

* Fix filter for symlinks

* Fine. Preserve ordering at the cost of readability

* Format

* Progress on new approach

* Remove unused tar path, fix up zip path to ignore symlinks, add test

* More tests

* Actually good for real this time
;

---------

Co-authored-by: Thomas Bouldin <[email protected]>

* Remove --open-sesame and --close-sesame (#9532)

* Lazy load commands (#9519)

* Refactor command loading to be lazy

- Updated `src/commands/index.ts` to make `loadCommand` return a lazy runner that only `require`s and registers the command when executed or explicitly loaded.
- Updated `src/index.ts` to handle lazy loading in the catch-all command handler by traversing the `client` object and loading the matching command before re-parsing arguments.
- Updated `src/bin/cli.ts` to load all commands when no arguments are provided (global help), ensuring the help text is fully populated.
- Added cycle detection to the `loadAll` logic to handle circular references in the `client` object.

* Refactor command loading to be lazy

- Updated `src/commands/index.ts` to make `loadCommand` return a lazy runner that only `require`s and registers the command when executed or explicitly loaded.
- Updated `src/index.ts` to handle lazy loading in the catch-all command handler by traversing the `client` object and loading the matching command before re-parsing arguments.
- Updated `src/bin/cli.ts` to load all commands when no arguments are provided (global help), ensuring the help text is fully populated.
- Added cycle detection to the `loadAll` logic to handle circular references in the `client` object.
- Added `scripts/benchmark_load.ts` to measure command load time.

* Fix help command as well

* Get rid of flawed benchmark test;

* Clean up unused vars

* Typeguards for style points

* Move typeguard

* Better types

* CHANGELOG

* More type cleanup

* No anys

* Fixing getCommand

* Bump timeout?

* 20s is better

* Removing extra timing code

* format

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

* BREAKING: Enforce strict timeout validation for functions (#9540)

* feat: enforce strict timeout validation for functions

* nit: run formatter

* docs: add changelog entry for timeout validation

* refactor: optimize timeout validation logic

* nit: add "breaking" prefix in changelog.

* bug: remove redundant timeout validation.

* feat: remove obsolete parseTriggers fallback (#9521)

* feat: remove obsolete parseTriggers fallback

* nit: clean up conditional paths

* feat(dataconnect): Update dataconnect:* commands to use flags for --service & --location (#9312)

* Update Firestore Emulator to v1.20.2 (#9565)

* Bump FS emulator version to 1.20.2

* Update CHANGELOG.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Co-authored-by: Joe Hanley <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Fix test broken by merge conflict

* format

* Update version in server.json

* Implement a `firebase init dataconnect:resolver` command. (#9493)

* Implement a `firebase init dataconnect:schema` command.

* Gate behind experiment flag and a few other fixes.

* Add unit tests.

* Fix unit tests.

* Rename command to `firebase init dataconnect:resolver`.

* Commit missed file.

* Fix default location in Cloud Run URL.

* Don't prompt for Cloud Run URL.

* Remove no-op line.

* Gate command at init level.

* [VS Code] Fix rendering of generate query code lens (#9588)

* Fix package-lock.json

* Fix missing auth:import and appdistribution:testers:remove commands (#9590)

* Fix missing auth:import and appdistribution:testers:remove commands

* Update CHANGELOG.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Dont pass undefined to getCommand (#9596)

* Fix --help (#9597)

* Fix --help

* handle firebase --help

* bump fdc emulator to v3 (#9602)

* FDC V3

* FDC V3

* merging

---------

Co-authored-by: oleina <[email protected]>
Co-authored-by: Joe Hanley <[email protected]>

* lint

---------

Co-authored-by: Fred Zhang <[email protected]>
Co-authored-by: Jamie Rothfeder <[email protected]>
Co-authored-by: Jamie Rothfeder <[email protected]>
Co-authored-by: Yuchen Shi <[email protected]>
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: Daniel Lee <[email protected]>
Co-authored-by: harshyyy21 <[email protected]>
Co-authored-by: Thomas Bouldin <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Rosalyn Tan <[email protected]>
Co-authored-by: Anthony Oleinik <[email protected]>
Co-authored-by: oleina <[email protected]>
joehan added a commit that referenced this pull request Dec 15, 2025
)

* Update next to match master (#9313)

* Remove overrides that diverge the test configuration from the build configuration. (#9300)

Co-authored-by: Jamie Rothfeder <[email protected]>

* Fix misleading typing for options.json. (#9275)

* feat(dataconnect): Add confirmation for Gemini schema generation (#9282)

* feat(dataconnect): add confirmation for Gemini schema generation

Instead of directly asking for an app description to generate a schema with Gemini, this change first asks the user to confirm if they want to use Gemini.

If the user confirms, it then prompts for the app description with a default value of "an app for ${setup.projectId}".

* prompts

* changelog

* m

* feedback

* typo

* metrics

* Update index.ts

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

---------

Co-authored-by: Jamie Rothfeder <[email protected]>
Co-authored-by: Jamie Rothfeder <[email protected]>
Co-authored-by: Yuchen Shi <[email protected]>
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

* BREAKING: clean up monkey patching in functions emulator runtime (#9402)

1. Removed `functions.config()` Polyfill
Removed initializeRuntimeConfig() from `src/emulator/functionsEmulatorRuntime.ts`. This function manually read `.runtimeconfig.json` and set `CLOUD_RUNTIME_CONFIG` env var to polyfill the logic for old clients of the Functions SDK. Functions SDK has included this feature for more than 5+ years now.

2. Removed Callable Auth Monkey Patches
Removed wrapCallableHandler from src/emulator/functionsEmulatorRuntime.ts. that handled manual auth header swapping logic in src/emulator/functionsEmulator.ts. We now rely on the SDK's built-in skipTokenVerification feature shipped since 3.16.0.

3. Bumped Minimum SDK Version
Increased minimum required firebase-functions version from 3.15.1 to 3.16.0 (launched 4+ years ago) in `src/emulator/functionsEmulatorRuntime.ts`. This ensures users have an SDK that supports skipTokenVerification and likely handles .runtimeconfig.json loading correctly in emulation.

* BREAKING: hide functions:config:* commands by default (#9340)

We'll gate all mutating functions:config:* commands behind the new `legacyRuntimeConfigCommands` experiment. We'll keep functions:config:{get,export} available for inspection.

Includes some minor refactoring to align deprecation message across all surfaces.

```shell
$ firebase functions:config:set FOO=bar

Error: DEPRECATION NOTICE: Action required before March 2026

The functions.config() API and the Cloud Runtime Config service are deprecated. Deploys that rely on functions.config() will fail once Runtime Config shuts down in March 2026.

The legacy functions:config:* CLI commands are deprecated and will be removed before March 2026.

Migrate configuration to the Firebase Functions params APIs:

  import { defineJsonSecret } from "firebase-functions/params";

  const config = defineJsonSecret("RUNTIME_CONFIG");

  exports.myFunction = functions
    .runWith({ secrets: [config] })
    .https.onRequest((req, res) => {
      const apiKey = config.value().service.key;
      // ...
    });

To convert existing runtime config values, try the interactive migration command:

  firebase functions:config:export

Learn more: https://firebase.google.com/docs/functions/config-env#migrate-config

To run this legacy command temporarily, run the following command and try again:

  firebase experiments:enable legacyRuntimeConfigCommands
```

* BREAKING: Rewrite functions:config:export command (#9341)

Target the new defineJsonSecret API as migration target for functions.config() usage. The new API is a simpler migration target for existing functions.config() use cases.

Example flow:

```shell
$ firebase functions:config:export
i  This command retrieves your Runtime Config values (accessed via functions.config()) and exports them as a Secret Manager secret.

i  Fetching your existing functions.config() from danielylee-90... ✔  Fetched your existing functions.config().

i  Configuration to be exported:
⚠  This may contain sensitive data. Do not share this output.

{
   <CONFIG>
}

✔ What would you like to name the new secret for your configuration? RUNTIME_CONFIG

✔  Created new secret version projects/XXX/secrets/RUNTIME_CONFIG/versions/1

i  To complete the migration, update your code:

  // Before:
  const functions = require('firebase-functions');

  exports.myFunction = functions.https.onRequest((req, res) => {
    const apiKey = functions.config().service.key;
    // ...
  });

  // After:
  const functions = require('firebase-functions');
  const { defineJsonSecret } = require('firebase-functions/params');

  const config = defineJsonSecret("RUNTIME_CONFIG");

  exports.myFunction = functions
    .runWith({ secrets: [config] })  // Bind secret here
    .https.onRequest((req, res) => {
      const apiKey = config.value().service.key;
      // ...
    });

i  Note: defineJsonSecret requires firebase-functions v6.6.0 or later. Update your package.json if needed. i  Then deploy your functions:
  firebase deploy --only functions
```

* feat(firestore): return listBackupsResponse from firestore:backups:list --json (#9392)

The `firestore:backups:list --json` command now returns the full `listBackupsResponse` object instead of just the `backups` array. This provides more information to the user, including a list of unreachable locations.

* Break java (#9451)

* error out java version below 21

* error out java version below 21

* error out java version below 21

* update formatting

* Remove duplicate error message

* Update CHANGELOG.md to include breaking change

* update CI to java 21

* Add setup-java action to integration

---------

Co-authored-by: Joe Hanley <[email protected]>

* Removing support for .bolt rules (#9339)

* Removing support for .bolt rules

* Changelog

* Merging in master

* Stop following symlinks when archiving directories (#9284)

* Stop following symlinks when archiving directories

* Update exfil PR (#9289)

* Fix filter for symlinks

* Fine. Preserve ordering at the cost of readability

* Format

* Progress on new approach

* Remove unused tar path, fix up zip path to ignore symlinks, add test

* More tests

* Actually good for real this time
;

---------

Co-authored-by: Thomas Bouldin <[email protected]>

* Remove --open-sesame and --close-sesame (#9532)

* Lazy load commands (#9519)

* Refactor command loading to be lazy

- Updated `src/commands/index.ts` to make `loadCommand` return a lazy runner that only `require`s and registers the command when executed or explicitly loaded.
- Updated `src/index.ts` to handle lazy loading in the catch-all command handler by traversing the `client` object and loading the matching command before re-parsing arguments.
- Updated `src/bin/cli.ts` to load all commands when no arguments are provided (global help), ensuring the help text is fully populated.
- Added cycle detection to the `loadAll` logic to handle circular references in the `client` object.

* Refactor command loading to be lazy

- Updated `src/commands/index.ts` to make `loadCommand` return a lazy runner that only `require`s and registers the command when executed or explicitly loaded.
- Updated `src/index.ts` to handle lazy loading in the catch-all command handler by traversing the `client` object and loading the matching command before re-parsing arguments.
- Updated `src/bin/cli.ts` to load all commands when no arguments are provided (global help), ensuring the help text is fully populated.
- Added cycle detection to the `loadAll` logic to handle circular references in the `client` object.
- Added `scripts/benchmark_load.ts` to measure command load time.

* Fix help command as well

* Get rid of flawed benchmark test;

* Clean up unused vars

* Typeguards for style points

* Move typeguard

* Better types

* CHANGELOG

* More type cleanup

* No anys

* Fixing getCommand

* Bump timeout?

* 20s is better

* Removing extra timing code

* format

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

* BREAKING: Enforce strict timeout validation for functions (#9540)

* feat: enforce strict timeout validation for functions

* nit: run formatter

* docs: add changelog entry for timeout validation

* refactor: optimize timeout validation logic

* nit: add "breaking" prefix in changelog.

* bug: remove redundant timeout validation.

* feat: remove obsolete parseTriggers fallback (#9521)

* feat: remove obsolete parseTriggers fallback

* nit: clean up conditional paths

* feat(dataconnect): Update dataconnect:* commands to use flags for --service & --location (#9312)

* Update Firestore Emulator to v1.20.2 (#9565)

* Bump FS emulator version to 1.20.2

* Update CHANGELOG.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Co-authored-by: Joe Hanley <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Fix test broken by merge conflict

* format

* Update version in server.json

* Performance improvements and new billing info for get_environment

* Implement a `firebase init dataconnect:resolver` command. (#9493)

* Implement a `firebase init dataconnect:schema` command.

* Gate behind experiment flag and a few other fixes.

* Add unit tests.

* Fix unit tests.

* Rename command to `firebase init dataconnect:resolver`.

* Commit missed file.

* Fix default location in Cloud Run URL.

* Don't prompt for Cloud Run URL.

* Remove no-op line.

* Gate command at init level.

* [VS Code] Fix rendering of generate query code lens (#9588)

* fix test

* Fix usage in mocks too

* Fix package-lock.json

* Fix missing auth:import and appdistribution:testers:remove commands (#9590)

* Fix missing auth:import and appdistribution:testers:remove commands

* Update CHANGELOG.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* lint

* Dont pass undefined to getCommand (#9596)

* Fix --help (#9597)

* Fix --help

* handle firebase --help

* bump fdc emulator to v3 (#9602)

* FDC V3

* FDC V3

* merging

---------

Co-authored-by: oleina <[email protected]>
Co-authored-by: Joe Hanley <[email protected]>

* lint

* Merging

* Get rid of uneeded intermediate variable

* Fix new test conflict

* Addressing flaky tests

---------

Co-authored-by: Fred Zhang <[email protected]>
Co-authored-by: Jamie Rothfeder <[email protected]>
Co-authored-by: Jamie Rothfeder <[email protected]>
Co-authored-by: Yuchen Shi <[email protected]>
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: Daniel Lee <[email protected]>
Co-authored-by: harshyyy21 <[email protected]>
Co-authored-by: Thomas Bouldin <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Rosalyn Tan <[email protected]>
Co-authored-by: Anthony Oleinik <[email protected]>
Co-authored-by: oleina <[email protected]>
andrewbrook pushed a commit that referenced this pull request Dec 16, 2025
* Update next to match master (#9313)

* Remove overrides that diverge the test configuration from the build configuration. (#9300)

Co-authored-by: Jamie Rothfeder <[email protected]>

* Fix misleading typing for options.json. (#9275)

* feat(dataconnect): Add confirmation for Gemini schema generation (#9282)

* feat(dataconnect): add confirmation for Gemini schema generation

Instead of directly asking for an app description to generate a schema with Gemini, this change first asks the user to confirm if they want to use Gemini.

If the user confirms, it then prompts for the app description with a default value of "an app for ${setup.projectId}".

* prompts

* changelog

* m

* feedback

* typo

* metrics

* Update index.ts

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

---------

Co-authored-by: Jamie Rothfeder <[email protected]>
Co-authored-by: Jamie Rothfeder <[email protected]>
Co-authored-by: Yuchen Shi <[email protected]>
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

* BREAKING: clean up monkey patching in functions emulator runtime (#9402)

1. Removed `functions.config()` Polyfill
Removed initializeRuntimeConfig() from `src/emulator/functionsEmulatorRuntime.ts`. This function manually read `.runtimeconfig.json` and set `CLOUD_RUNTIME_CONFIG` env var to polyfill the logic for old clients of the Functions SDK. Functions SDK has included this feature for more than 5+ years now.

2. Removed Callable Auth Monkey Patches
Removed wrapCallableHandler from src/emulator/functionsEmulatorRuntime.ts. that handled manual auth header swapping logic in src/emulator/functionsEmulator.ts. We now rely on the SDK's built-in skipTokenVerification feature shipped since 3.16.0.

3. Bumped Minimum SDK Version
Increased minimum required firebase-functions version from 3.15.1 to 3.16.0 (launched 4+ years ago) in `src/emulator/functionsEmulatorRuntime.ts`. This ensures users have an SDK that supports skipTokenVerification and likely handles .runtimeconfig.json loading correctly in emulation.

* BREAKING: hide functions:config:* commands by default (#9340)

We'll gate all mutating functions:config:* commands behind the new `legacyRuntimeConfigCommands` experiment. We'll keep functions:config:{get,export} available for inspection.

Includes some minor refactoring to align deprecation message across all surfaces.

```shell
$ firebase functions:config:set FOO=bar

Error: DEPRECATION NOTICE: Action required before March 2026

The functions.config() API and the Cloud Runtime Config service are deprecated. Deploys that rely on functions.config() will fail once Runtime Config shuts down in March 2026.

The legacy functions:config:* CLI commands are deprecated and will be removed before March 2026.

Migrate configuration to the Firebase Functions params APIs:

  import { defineJsonSecret } from "firebase-functions/params";

  const config = defineJsonSecret("RUNTIME_CONFIG");

  exports.myFunction = functions
    .runWith({ secrets: [config] })
    .https.onRequest((req, res) => {
      const apiKey = config.value().service.key;
      // ...
    });

To convert existing runtime config values, try the interactive migration command:

  firebase functions:config:export

Learn more: https://firebase.google.com/docs/functions/config-env#migrate-config

To run this legacy command temporarily, run the following command and try again:

  firebase experiments:enable legacyRuntimeConfigCommands
```

* BREAKING: Rewrite functions:config:export command (#9341)

Target the new defineJsonSecret API as migration target for functions.config() usage. The new API is a simpler migration target for existing functions.config() use cases.

Example flow:

```shell
$ firebase functions:config:export
i  This command retrieves your Runtime Config values (accessed via functions.config()) and exports them as a Secret Manager secret.

i  Fetching your existing functions.config() from danielylee-90... ✔  Fetched your existing functions.config().

i  Configuration to be exported:
⚠  This may contain sensitive data. Do not share this output.

{
   <CONFIG>
}

✔ What would you like to name the new secret for your configuration? RUNTIME_CONFIG

✔  Created new secret version projects/XXX/secrets/RUNTIME_CONFIG/versions/1

i  To complete the migration, update your code:

  // Before:
  const functions = require('firebase-functions');

  exports.myFunction = functions.https.onRequest((req, res) => {
    const apiKey = functions.config().service.key;
    // ...
  });

  // After:
  const functions = require('firebase-functions');
  const { defineJsonSecret } = require('firebase-functions/params');

  const config = defineJsonSecret("RUNTIME_CONFIG");

  exports.myFunction = functions
    .runWith({ secrets: [config] })  // Bind secret here
    .https.onRequest((req, res) => {
      const apiKey = config.value().service.key;
      // ...
    });

i  Note: defineJsonSecret requires firebase-functions v6.6.0 or later. Update your package.json if needed. i  Then deploy your functions:
  firebase deploy --only functions
```

* feat(firestore): return listBackupsResponse from firestore:backups:list --json (#9392)

The `firestore:backups:list --json` command now returns the full `listBackupsResponse` object instead of just the `backups` array. This provides more information to the user, including a list of unreachable locations.

* Break java (#9451)

* error out java version below 21

* error out java version below 21

* error out java version below 21

* update formatting

* Remove duplicate error message

* Update CHANGELOG.md to include breaking change

* update CI to java 21

* Add setup-java action to integration

---------

Co-authored-by: Joe Hanley <[email protected]>

* Removing support for .bolt rules (#9339)

* Removing support for .bolt rules

* Changelog

* Merging in master

* Stop following symlinks when archiving directories (#9284)

* Stop following symlinks when archiving directories

* Update exfil PR (#9289)

* Fix filter for symlinks

* Fine. Preserve ordering at the cost of readability

* Format

* Progress on new approach

* Remove unused tar path, fix up zip path to ignore symlinks, add test

* More tests

* Actually good for real this time
;

---------

Co-authored-by: Thomas Bouldin <[email protected]>

* Remove --open-sesame and --close-sesame (#9532)

* Lazy load commands (#9519)

* Refactor command loading to be lazy

- Updated `src/commands/index.ts` to make `loadCommand` return a lazy runner that only `require`s and registers the command when executed or explicitly loaded.
- Updated `src/index.ts` to handle lazy loading in the catch-all command handler by traversing the `client` object and loading the matching command before re-parsing arguments.
- Updated `src/bin/cli.ts` to load all commands when no arguments are provided (global help), ensuring the help text is fully populated.
- Added cycle detection to the `loadAll` logic to handle circular references in the `client` object.

* Refactor command loading to be lazy

- Updated `src/commands/index.ts` to make `loadCommand` return a lazy runner that only `require`s and registers the command when executed or explicitly loaded.
- Updated `src/index.ts` to handle lazy loading in the catch-all command handler by traversing the `client` object and loading the matching command before re-parsing arguments.
- Updated `src/bin/cli.ts` to load all commands when no arguments are provided (global help), ensuring the help text is fully populated.
- Added cycle detection to the `loadAll` logic to handle circular references in the `client` object.
- Added `scripts/benchmark_load.ts` to measure command load time.

* Fix help command as well

* Get rid of flawed benchmark test;

* Clean up unused vars

* Typeguards for style points

* Move typeguard

* Better types

* CHANGELOG

* More type cleanup

* No anys

* Fixing getCommand

* Bump timeout?

* 20s is better

* Removing extra timing code

* format

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

* BREAKING: Enforce strict timeout validation for functions (#9540)

* feat: enforce strict timeout validation for functions

* nit: run formatter

* docs: add changelog entry for timeout validation

* refactor: optimize timeout validation logic

* nit: add "breaking" prefix in changelog.

* bug: remove redundant timeout validation.

* feat: remove obsolete parseTriggers fallback (#9521)

* feat: remove obsolete parseTriggers fallback

* nit: clean up conditional paths

* feat(dataconnect): Update dataconnect:* commands to use flags for --service & --location (#9312)

* Update Firestore Emulator to v1.20.2 (#9565)

* Bump FS emulator version to 1.20.2

* Update CHANGELOG.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Co-authored-by: Joe Hanley <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Fix test broken by merge conflict

* format

* Update version in server.json

* Implement a `firebase init dataconnect:resolver` command. (#9493)

* Implement a `firebase init dataconnect:schema` command.

* Gate behind experiment flag and a few other fixes.

* Add unit tests.

* Fix unit tests.

* Rename command to `firebase init dataconnect:resolver`.

* Commit missed file.

* Fix default location in Cloud Run URL.

* Don't prompt for Cloud Run URL.

* Remove no-op line.

* Gate command at init level.

* [VS Code] Fix rendering of generate query code lens (#9588)

* Fix package-lock.json

* Fix missing auth:import and appdistribution:testers:remove commands (#9590)

* Fix missing auth:import and appdistribution:testers:remove commands

* Update CHANGELOG.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Dont pass undefined to getCommand (#9596)

* Fix --help (#9597)

* Fix --help

* handle firebase --help

* bump fdc emulator to v3 (#9602)

* FDC V3

* FDC V3

* merging

---------

Co-authored-by: oleina <[email protected]>
Co-authored-by: Joe Hanley <[email protected]>

* lint

---------

Co-authored-by: Fred Zhang <[email protected]>
Co-authored-by: Jamie Rothfeder <[email protected]>
Co-authored-by: Jamie Rothfeder <[email protected]>
Co-authored-by: Yuchen Shi <[email protected]>
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: Daniel Lee <[email protected]>
Co-authored-by: harshyyy21 <[email protected]>
Co-authored-by: Thomas Bouldin <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Rosalyn Tan <[email protected]>
Co-authored-by: Anthony Oleinik <[email protected]>
Co-authored-by: oleina <[email protected]>
andrewbrook pushed a commit that referenced this pull request Dec 16, 2025
)

* Update next to match master (#9313)

* Remove overrides that diverge the test configuration from the build configuration. (#9300)

Co-authored-by: Jamie Rothfeder <[email protected]>

* Fix misleading typing for options.json. (#9275)

* feat(dataconnect): Add confirmation for Gemini schema generation (#9282)

* feat(dataconnect): add confirmation for Gemini schema generation

Instead of directly asking for an app description to generate a schema with Gemini, this change first asks the user to confirm if they want to use Gemini.

If the user confirms, it then prompts for the app description with a default value of "an app for ${setup.projectId}".

* prompts

* changelog

* m

* feedback

* typo

* metrics

* Update index.ts

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

---------

Co-authored-by: Jamie Rothfeder <[email protected]>
Co-authored-by: Jamie Rothfeder <[email protected]>
Co-authored-by: Yuchen Shi <[email protected]>
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

* BREAKING: clean up monkey patching in functions emulator runtime (#9402)

1. Removed `functions.config()` Polyfill
Removed initializeRuntimeConfig() from `src/emulator/functionsEmulatorRuntime.ts`. This function manually read `.runtimeconfig.json` and set `CLOUD_RUNTIME_CONFIG` env var to polyfill the logic for old clients of the Functions SDK. Functions SDK has included this feature for more than 5+ years now.

2. Removed Callable Auth Monkey Patches
Removed wrapCallableHandler from src/emulator/functionsEmulatorRuntime.ts. that handled manual auth header swapping logic in src/emulator/functionsEmulator.ts. We now rely on the SDK's built-in skipTokenVerification feature shipped since 3.16.0.

3. Bumped Minimum SDK Version
Increased minimum required firebase-functions version from 3.15.1 to 3.16.0 (launched 4+ years ago) in `src/emulator/functionsEmulatorRuntime.ts`. This ensures users have an SDK that supports skipTokenVerification and likely handles .runtimeconfig.json loading correctly in emulation.

* BREAKING: hide functions:config:* commands by default (#9340)

We'll gate all mutating functions:config:* commands behind the new `legacyRuntimeConfigCommands` experiment. We'll keep functions:config:{get,export} available for inspection.

Includes some minor refactoring to align deprecation message across all surfaces.

```shell
$ firebase functions:config:set FOO=bar

Error: DEPRECATION NOTICE: Action required before March 2026

The functions.config() API and the Cloud Runtime Config service are deprecated. Deploys that rely on functions.config() will fail once Runtime Config shuts down in March 2026.

The legacy functions:config:* CLI commands are deprecated and will be removed before March 2026.

Migrate configuration to the Firebase Functions params APIs:

  import { defineJsonSecret } from "firebase-functions/params";

  const config = defineJsonSecret("RUNTIME_CONFIG");

  exports.myFunction = functions
    .runWith({ secrets: [config] })
    .https.onRequest((req, res) => {
      const apiKey = config.value().service.key;
      // ...
    });

To convert existing runtime config values, try the interactive migration command:

  firebase functions:config:export

Learn more: https://firebase.google.com/docs/functions/config-env#migrate-config

To run this legacy command temporarily, run the following command and try again:

  firebase experiments:enable legacyRuntimeConfigCommands
```

* BREAKING: Rewrite functions:config:export command (#9341)

Target the new defineJsonSecret API as migration target for functions.config() usage. The new API is a simpler migration target for existing functions.config() use cases.

Example flow:

```shell
$ firebase functions:config:export
i  This command retrieves your Runtime Config values (accessed via functions.config()) and exports them as a Secret Manager secret.

i  Fetching your existing functions.config() from danielylee-90... ✔  Fetched your existing functions.config().

i  Configuration to be exported:
⚠  This may contain sensitive data. Do not share this output.

{
   <CONFIG>
}

✔ What would you like to name the new secret for your configuration? RUNTIME_CONFIG

✔  Created new secret version projects/XXX/secrets/RUNTIME_CONFIG/versions/1

i  To complete the migration, update your code:

  // Before:
  const functions = require('firebase-functions');

  exports.myFunction = functions.https.onRequest((req, res) => {
    const apiKey = functions.config().service.key;
    // ...
  });

  // After:
  const functions = require('firebase-functions');
  const { defineJsonSecret } = require('firebase-functions/params');

  const config = defineJsonSecret("RUNTIME_CONFIG");

  exports.myFunction = functions
    .runWith({ secrets: [config] })  // Bind secret here
    .https.onRequest((req, res) => {
      const apiKey = config.value().service.key;
      // ...
    });

i  Note: defineJsonSecret requires firebase-functions v6.6.0 or later. Update your package.json if needed. i  Then deploy your functions:
  firebase deploy --only functions
```

* feat(firestore): return listBackupsResponse from firestore:backups:list --json (#9392)

The `firestore:backups:list --json` command now returns the full `listBackupsResponse` object instead of just the `backups` array. This provides more information to the user, including a list of unreachable locations.

* Break java (#9451)

* error out java version below 21

* error out java version below 21

* error out java version below 21

* update formatting

* Remove duplicate error message

* Update CHANGELOG.md to include breaking change

* update CI to java 21

* Add setup-java action to integration

---------

Co-authored-by: Joe Hanley <[email protected]>

* Removing support for .bolt rules (#9339)

* Removing support for .bolt rules

* Changelog

* Merging in master

* Stop following symlinks when archiving directories (#9284)

* Stop following symlinks when archiving directories

* Update exfil PR (#9289)

* Fix filter for symlinks

* Fine. Preserve ordering at the cost of readability

* Format

* Progress on new approach

* Remove unused tar path, fix up zip path to ignore symlinks, add test

* More tests

* Actually good for real this time
;

---------

Co-authored-by: Thomas Bouldin <[email protected]>

* Remove --open-sesame and --close-sesame (#9532)

* Lazy load commands (#9519)

* Refactor command loading to be lazy

- Updated `src/commands/index.ts` to make `loadCommand` return a lazy runner that only `require`s and registers the command when executed or explicitly loaded.
- Updated `src/index.ts` to handle lazy loading in the catch-all command handler by traversing the `client` object and loading the matching command before re-parsing arguments.
- Updated `src/bin/cli.ts` to load all commands when no arguments are provided (global help), ensuring the help text is fully populated.
- Added cycle detection to the `loadAll` logic to handle circular references in the `client` object.

* Refactor command loading to be lazy

- Updated `src/commands/index.ts` to make `loadCommand` return a lazy runner that only `require`s and registers the command when executed or explicitly loaded.
- Updated `src/index.ts` to handle lazy loading in the catch-all command handler by traversing the `client` object and loading the matching command before re-parsing arguments.
- Updated `src/bin/cli.ts` to load all commands when no arguments are provided (global help), ensuring the help text is fully populated.
- Added cycle detection to the `loadAll` logic to handle circular references in the `client` object.
- Added `scripts/benchmark_load.ts` to measure command load time.

* Fix help command as well

* Get rid of flawed benchmark test;

* Clean up unused vars

* Typeguards for style points

* Move typeguard

* Better types

* CHANGELOG

* More type cleanup

* No anys

* Fixing getCommand

* Bump timeout?

* 20s is better

* Removing extra timing code

* format

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

* BREAKING: Enforce strict timeout validation for functions (#9540)

* feat: enforce strict timeout validation for functions

* nit: run formatter

* docs: add changelog entry for timeout validation

* refactor: optimize timeout validation logic

* nit: add "breaking" prefix in changelog.

* bug: remove redundant timeout validation.

* feat: remove obsolete parseTriggers fallback (#9521)

* feat: remove obsolete parseTriggers fallback

* nit: clean up conditional paths

* feat(dataconnect): Update dataconnect:* commands to use flags for --service & --location (#9312)

* Update Firestore Emulator to v1.20.2 (#9565)

* Bump FS emulator version to 1.20.2

* Update CHANGELOG.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Co-authored-by: Joe Hanley <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Fix test broken by merge conflict

* format

* Update version in server.json

* Performance improvements and new billing info for get_environment

* Implement a `firebase init dataconnect:resolver` command. (#9493)

* Implement a `firebase init dataconnect:schema` command.

* Gate behind experiment flag and a few other fixes.

* Add unit tests.

* Fix unit tests.

* Rename command to `firebase init dataconnect:resolver`.

* Commit missed file.

* Fix default location in Cloud Run URL.

* Don't prompt for Cloud Run URL.

* Remove no-op line.

* Gate command at init level.

* [VS Code] Fix rendering of generate query code lens (#9588)

* fix test

* Fix usage in mocks too

* Fix package-lock.json

* Fix missing auth:import and appdistribution:testers:remove commands (#9590)

* Fix missing auth:import and appdistribution:testers:remove commands

* Update CHANGELOG.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* lint

* Dont pass undefined to getCommand (#9596)

* Fix --help (#9597)

* Fix --help

* handle firebase --help

* bump fdc emulator to v3 (#9602)

* FDC V3

* FDC V3

* merging

---------

Co-authored-by: oleina <[email protected]>
Co-authored-by: Joe Hanley <[email protected]>

* lint

* Merging

* Get rid of uneeded intermediate variable

* Fix new test conflict

* Addressing flaky tests

---------

Co-authored-by: Fred Zhang <[email protected]>
Co-authored-by: Jamie Rothfeder <[email protected]>
Co-authored-by: Jamie Rothfeder <[email protected]>
Co-authored-by: Yuchen Shi <[email protected]>
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: Daniel Lee <[email protected]>
Co-authored-by: harshyyy21 <[email protected]>
Co-authored-by: Thomas Bouldin <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Rosalyn Tan <[email protected]>
Co-authored-by: Anthony Oleinik <[email protected]>
Co-authored-by: oleina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants